Skip to content

nomeiryoui@3.4.0: Remove architecture field, add shortcuts#16875

Merged
z-Fng merged 2 commits intoScoopInstaller:masterfrom
scillidan:nomeiryoui@3.4.0
Dec 25, 2025
Merged

nomeiryoui@3.4.0: Remove architecture field, add shortcuts#16875
z-Fng merged 2 commits intoScoopInstaller:masterfrom
scillidan:nomeiryoui@3.4.0

Conversation

@scillidan
Copy link
Contributor

@scillidan scillidan commented Dec 24, 2025 •
edited by coderabbitai bot
Loading

The Detect-It-Easy show it be 32-bit. So can write its architecture to url.

image
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Unified distribution and autoupdate into a single, architecture-agnostic configuration to simplify updates.
  • Bug Fixes
    • Adjusted installation behavior and executable mapping to improve install consistency.
  • Other
    • Updated shipped shortcut label to "No!! Meiryo UI" for clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 24, 2025 •
edited
Loading

Walkthrough

Consolidated architecture-specific manifest entries in bucket/nomeiryoui.json into single root-level url/hash and unified autoupdate.url; converted pre_install to an array, changed bin to a string, and updated a shortcut label.

Changes

Cohort / File(s) Summary
Manifest: single-file changes
bucket/nomeiryoui.json		 Replaced root architecture object (64bit/32bit) with root-level url and hash; removed architecture entries under autoupdate and added autoupdate.url; changed pre_install from string to array; changed bin from array to single string; updated shortcuts second value from "noMeiryoUI" to "No!! Meiryo UI"

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰
Binaries once split by size and name,
I hopped about and fixed the frame.
One URL now, one hash so neat,
Pre-install steps in tidy beat.
NoMeiryoUI now sings: "No!! Meiryo UI" 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'nomeiryoui@3.4.0: Update architecture write' accurately describes the main change: updating the manifest for nomeiryoui to refactor architecture-specific entries into url fields.
Description check ✅ Passed The description includes checked items confirming use of conventional PR title and reading the Contributing Guide, but lacks detailed explanation of the actual manifest changes and how they address the Detect-It-Easy findings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b4f97a and 910db8e.

📒 Files selected for processing (1)
  • bucket/nomeiryoui.json
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings 
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.

Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.

Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.

Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.

Learnt from: Ra2-IFV
Repo: ScoopInstaller/Extras PR: 16672
File: bucket/chromium-clang.json:12-12
Timestamp: 2025-11-29T22:02:34.868Z
Learning: In the chromium-clang.json manifest (bucket/chromium-clang.json), the extract_dir value "chrome-win32" is a fixed name determined by the upstream Chromium_Clang archive structure and should not be changed, even though the manifest targets 64-bit architecture.

Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.
📚 Learning: 2025-11-29T22:02:34.868Z 
Learnt from: Ra2-IFV
Repo: ScoopInstaller/Extras PR: 16672
File: bucket/chromium-clang.json:12-12
Timestamp: 2025-11-29T22:02:34.868Z
Learning: In the chromium-clang.json manifest (bucket/chromium-clang.json), the extract_dir value "chrome-win32" is a fixed name determined by the upstream Chromium_Clang archive structure and should not be changed, even though the manifest targets 64-bit architecture.

Applied to files:

  • bucket/nomeiryoui.json
📚 Learning: 2025-10-16T15:59:21.258Z 
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.

Applied to files:

  • bucket/nomeiryoui.json
📚 Learning: 2025-09-05T09:41:52.653Z 
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.

Applied to files:

  • bucket/nomeiryoui.json
📚 Learning: 2025-09-05T09:41:52.653Z 
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.

Applied to files:

  • bucket/nomeiryoui.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (5)
bucket/nomeiryoui.json (5)

8-12: LGTM! Pre-install script correctly implements reviewer feedback.

The script now:

  • Uses array format for multi-line PowerShell commands
  • Checks if the INI file already exists in the persist directory before creating it
  • Suppresses output with Out-Null to prevent unnecessary console messages
  • Avoids creating unwanted .original files

This implementation matches the reviewer's requirements and example.

13-13: LGTM! Bin field correctly simplified.

The bin field has been appropriately changed from an array to a simple string, which is the preferred format when defining a single executable without aliases.

14-18: LGTM! Shortcuts field added as requested.

The shortcuts entry correctly creates a Start Menu shortcut with the display name "No!! Meiryo UI", which matches the application's branding and implements the reviewer's feedback.

27-27: LGTM! Autoupdate URL correctly simplified.

The autoupdate URL has been appropriately consolidated to a single pattern without architecture-specific variants. The URL template correctly uses $version variable substitution and matches the current release URL format.

6-7: Verify the hash matches the actual file.

The URL structure is correct and the release asset exists, but the hash value could not be verified in the sandbox environment. Please ensure the hash 97b7d4eb6b04c9a4a617267823fa98c75ae5559765ecb5c1192ee473d4e78ec8 is correct for the actual noMeiryoUI3.4.0.zip file from the TAG-3.4.0 release.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

All changes look good.

Wait for review from human collaborators.

nomeiryoui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@SorYoshino
Copy link
Contributor

SorYoshino commented Dec 24, 2025

Please modify the pre_install script in the manifest to suppress unnecessary output and prevent the creation of noMeiryoUI.ini.original. In addition, please add the shortcuts field.

The test results are as follows: 
┏[ ~]
└─> scoop update noMeiryoUI -f
noMeiryoUI: 3.4.0 -> 3.4.0
Updating one outdated app:
Updating 'noMeiryoUI' (3.4.0 -> 3.4.0)
Downloading new version
Loading noMeiryoUI3.4.0.zip from cache.
Checking hash of noMeiryoUI3.4.0.zip ... ok.
Uninstalling 'noMeiryoUI' (3.4.0)
Removing shim 'noMeiryoUI.shim'.
Removing shim 'noMeiryoUI.exe'.
Unlinking D:\Software\Scoop\Local\apps\noMeiryoUI\current
Installing 'noMeiryoUI' (3.4.0) [64bit] from 'Extras' bucket
Loading noMeiryoUI3.4.0.zip from cache.
Extracting noMeiryoUI3.4.0.zip ... done.
Running pre_install script...
        Directory: D:\Software\Scoop\Local\apps\noMeiryoUI\3.4.0


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a---        2025/12/25      1:03              0   noMeiryoUI.ini
done.
Linking D:\Software\Scoop\Local\apps\noMeiryoUI\current => D:\Software\Scoop\Local\apps\noMeiryoUI\3.4.0
Creating shim for 'noMeiryoUI'.
Making D:\Software\Scoop\Local\shims\nomeiryoui.exe a GUI binary.
Persisting noMeiryoUI.ini
'noMeiryoUI' (3.4.0) was installed successfully!

┏[ ~]
└─> Get-ChildItem -Path $(scoop prefix noMeiryoUI) -Filter 'noMeiryoUI.ini*'

        Directory: D:\Software\Scoop\Local\apps\noMeiryoUI\current


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
la---        2025/12/21     16:01             48   noMeiryoUI.ini
-a---        2025/12/25      1:03              0   noMeiryoUI.ini.original
An example of the revised version is provided below: 
┏[ D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Unofficial][ master ≡]
└─> jq '{pre_install, bin, shortcuts}' '.\bucket\n\nomeiryoui.json'
{
  "pre_install": [
    "if (-not (Test-Path \"$persist_dir\\noMeiryoUI.ini\")) {",
    "    New-Item -Path \"$dir\\noMeiryoUI.ini\" -ItemType File -Force | Out-Null",
    "}"
  ],
  "bin": "noMeiryoUI.exe",
  "shortcuts": [
    [
      "noMeiryoUI.exe",
      "No!! Meiryo UI"
    ]
  ]
}

@z-Fng
Copy link
Member

z-Fng commented Dec 25, 2025 •
edited
Loading

Please modify the pre_install script in the manifest to suppress unnecessary output and prevent the creation of noMeiryoUI.ini.original. In addition, please add the shortcuts field.

Please create a separate PR for this change next time, as others may not fully understand the change you're trying to make. #16452 is a good example of why.

@z-Fng z-Fng changed the title nomeiryoui@3.4.0: Update architecture write nomeiryoui@3.4.0: Remove architecture field, add shortcuts Dec 25, 2025
@z-Fng
Copy link
Member

z-Fng commented Dec 25, 2025

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2025

All changes look good.

Wait for review from human collaborators.

nomeiryoui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

z-Fng
z-Fng approved these changes Dec 25, 2025
View reviewed changes
Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both for your contributions!

@z-Fng z-Fng merged commit 15c426f into ScoopInstaller:master Dec 25, 2025
3 checks passed
@SorYoshino
Copy link
Contributor

SorYoshino commented Dec 25, 2025

Please create a separate PR for this change next time, as others may not fully understand the change you're trying to make. #16452 is a good example of why.

Ok, thank you for your reminder.

@scillidan scillidan deleted the nomeiryoui@3.4.0 branch December 28, 2025 07:41
@coderabbitai coderabbitai bot mentioned this pull request Dec 30, 2025
Merged
3 tasks
This was referenced Jan 16, 2026
Closed
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jan 27, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z-Fng z-Fng z-Fng approved these changes

Assignees

No one assigned

Labels

review-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scillidan @SorYoshino @z-Fng